lxbfYeaa/PayPal-PHP-SDK
Archived
Template
1
0
Fork 0
forked from LiveCarta/PayPal-PHP-SDK
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove automatic retries

Browse Source
This commit is contained in:
brluk and dkatz
2016-12-13 20:56:30 +00:00
parent a2c75921cb
commit 6a8e97db09
1 changed files with 1 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
lib/PayPal/Core/PayPalHttpConnection.php
View File

@@ -18,13 +18,6 @@ class PayPalHttpConnection
*/ */
private $httpConfig; private $httpConfig;
/**
* HTTP status codes for which a retry must be attempted
* retry is currently attempted for Request timeout, Bad Gateway,
* Service Unavailable and Gateway timeout errors.
*/
private static $retryCodes = array('408', '502', '503', '504',);
/** /**
* LoggingManager * LoggingManager
* *
@@ -124,17 +117,6 @@ class PayPalHttpConnection
$httpStatus = curl_getinfo($ch, CURLINFO_HTTP_CODE); $httpStatus = curl_getinfo($ch, CURLINFO_HTTP_CODE);
} }
//Retry if Failing
$retries = 0;
if (in_array($httpStatus, self::$retryCodes) && $this->httpConfig->getHttpRetryCount() != null) {
$this->logger->info("Got $httpStatus response from server. Retrying");
do {
$result = curl_exec($ch);
//Retrieve Response Status
$httpStatus = curl_getinfo($ch, CURLINFO_HTTP_CODE);
} while (in_array($httpStatus, self::$retryCodes) && (++$retries < $this->httpConfig->getHttpRetryCount()));
}
//Throw Exception if Retries and Certificates doenst work //Throw Exception if Retries and Certificates doenst work
if (curl_errno($ch)) { if (curl_errno($ch)) {
$ex = new PayPalConnectionException( $ex = new PayPalConnectionException(
@@ -168,18 +150,7 @@ class PayPalHttpConnection
curl_close($ch); curl_close($ch);
//More Exceptions based on HttpStatus Code //More Exceptions based on HttpStatus Code
if (in_array($httpStatus, self::$retryCodes)) { if ($httpStatus < 200 || $httpStatus >= 300) {
$ex = new PayPalConnectionException(
$this->httpConfig->getUrl(),
"Got Http response code $httpStatus when accessing {$this->httpConfig->getUrl()}. " .
"Retried $retries times."
);
$ex->setData($result);
$this->logger->error("Got Http response code $httpStatus when accessing {$this->httpConfig->getUrl()}. " .
"Retried $retries times." . $result);
$this->logger->debug("\n\n" . str_repeat('=', 128) . "\n");
throw $ex;
} elseif ($httpStatus < 200 || $httpStatus >= 300) {
$ex = new PayPalConnectionException( $ex = new PayPalConnectionException(
$this->httpConfig->getUrl(), $this->httpConfig->getUrl(),
"Got Http response code $httpStatus when accessing {$this->httpConfig->getUrl()}.", "Got Http response code $httpStatus when accessing {$this->httpConfig->getUrl()}.",